From 52bb0e749e17303c125ae9e4c7644800c32a2bcc Mon Sep 17 00:00:00 2001 From: rvcas Date: Mon, 20 Feb 2023 13:19:52 -0500 Subject: [PATCH] fix(lsp): cannot blindly run publish after handle_request --- crates/aiken-lsp/src/server.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/aiken-lsp/src/server.rs b/crates/aiken-lsp/src/server.rs index c7974e40..b190ed9a 100644 --- a/crates/aiken-lsp/src/server.rs +++ b/crates/aiken-lsp/src/server.rs @@ -239,6 +239,7 @@ impl Server { fn handle_request( &mut self, request: lsp_server::Request, + connection: &Connection, ) -> Result { let id = request.id.clone(); @@ -263,6 +264,8 @@ impl Server { self.process_diagnostic(error)?; } + self.publish_stored_diagnostics(connection)?; + Ok(lsp_server::Response { id, error: None, @@ -497,9 +500,7 @@ impl Server { tracing::debug!("Get request: {:#?}", req); - let response = self.handle_request(req)?; - - self.publish_stored_diagnostics(&connection)?; + let response = self.handle_request(req, &connection)?; connection.sender.send(Message::Response(response))?; }