From 7ff6eba869cb63ccd31c2ef4f276ba0183ef8560 Mon Sep 17 00:00:00 2001
From: KtorZ <matthias.benkort@gmail.com>
Date: Thu, 16 May 2024 23:42:53 +0200
Subject: [PATCH] Prefer '.clone_from' over mutating a clone.

  Clippy says it's more efficient. I trust clippy. Clippy good.
---
 crates/aiken-lang/src/gen_uplc.rs                    | 2 +-
 crates/aiken-lang/src/parser/definition/data_type.rs | 5 ++---
 crates/aiken-lang/src/tipo/error.rs                  | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/crates/aiken-lang/src/gen_uplc.rs b/crates/aiken-lang/src/gen_uplc.rs
index 5ce4b72b..dfd9a093 100644
--- a/crates/aiken-lang/src/gen_uplc.rs
+++ b/crates/aiken-lang/src/gen_uplc.rs
@@ -3918,7 +3918,7 @@ impl<'a> CodeGenerator<'a> {
                         .map(|(_, tipo)| get_generic_variant_name(tipo))
                         .join("");
 
-                    *variant_name = variant.clone();
+                    variant_name.clone_from(&variant);
 
                     if !dependency_functions
                         .iter()
diff --git a/crates/aiken-lang/src/parser/definition/data_type.rs b/crates/aiken-lang/src/parser/definition/data_type.rs
index 1137481f..2785ddce 100644
--- a/crates/aiken-lang/src/parser/definition/data_type.rs
+++ b/crates/aiken-lang/src/parser/definition/data_type.rs
@@ -1,9 +1,8 @@
-use chumsky::prelude::*;
-
 use crate::{
     ast,
     parser::{annotation, error::ParseError, token::Token, utils},
 };
+use chumsky::prelude::*;
 
 pub fn parser() -> impl Parser<Token, ast::UntypedDefinition, Error = ParseError> {
     let unlabeled_constructor_type_args = annotation()
@@ -67,7 +66,7 @@ pub fn parser() -> impl Parser<Token, ast::UntypedDefinition, Error = ParseError
                             .into_iter()
                             .map(|mut constructor| {
                                 if constructor.sugar {
-                                    constructor.name = name.clone();
+                                    constructor.name.clone_from(&name);
                                 }
 
                                 constructor
diff --git a/crates/aiken-lang/src/tipo/error.rs b/crates/aiken-lang/src/tipo/error.rs
index 53d5192a..9ff18658 100644
--- a/crates/aiken-lang/src/tipo/error.rs
+++ b/crates/aiken-lang/src/tipo/error.rs
@@ -1150,7 +1150,7 @@ impl Error {
                 rigid_type_names: ref mut annotated_names,
                 ..
             } => {
-                *annotated_names = new_names.clone();
+                annotated_names.clone_from(new_names);
                 self
             }
             _ => self,