Fix: issue crash in code gen with incorrect column length in decision trees (#1069)

* Fix: Deeply nested assignments would offset the new columns count calculation. Now we track relevant columns and their path to ensure each row has wildcards if they don't contain the relevant column

* Add test plus clippy fix

* Clippy fix

* New version clippy fix
This commit is contained in:
Kasey
2024-12-05 11:02:19 +07:00
committed by GitHub
parent a9675fedc6
commit 86ec3b2924
13 changed files with 392 additions and 183 deletions

View File

@@ -52,7 +52,7 @@ struct ModuleTemplate<'a> {
timestamp: String,
}
impl<'a> ModuleTemplate<'a> {
impl ModuleTemplate<'_> {
pub fn is_current_module(&self, module: &DocLink) -> bool {
match module.path.split(".html").next() {
None => false,
@@ -75,7 +75,7 @@ struct PageTemplate<'a> {
timestamp: &'a str,
}
impl<'a> PageTemplate<'a> {
impl PageTemplate<'_> {
pub fn is_current_module(&self, _module: &DocLink) -> bool {
false
}

View File

@@ -720,7 +720,7 @@ struct DisplayWarning<'a> {
help: Option<String>,
}
impl<'a> Diagnostic for DisplayWarning<'a> {
impl Diagnostic for DisplayWarning<'_> {
fn severity(&self) -> Option<miette::Severity> {
Some(miette::Severity::Warning)
}
@@ -749,7 +749,7 @@ impl<'a> Diagnostic for DisplayWarning<'a> {
}
}
impl<'a> Debug for DisplayWarning<'a> {
impl Debug for DisplayWarning<'_> {
fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
unreachable!("Display warning are never shown directly.");
}

View File

@@ -74,7 +74,7 @@ impl<'de> Deserialize<'de> for PackageName {
{
struct PackageNameVisitor;
impl<'de> Visitor<'de> for PackageNameVisitor {
impl Visitor<'_> for PackageNameVisitor {
type Value = PackageName;
fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {